Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Need to implement logic to detect transient failures for nonidempotent steps #874

Open
ronnaksaxena opened this issue Jul 26, 2023 · 0 comments
Labels
bug Something isn't working ism action medium

Comments

@ronnaksaxena
Copy link
Contributor

What is the bug?
This is a follow up to issue33 that displays an inappropriate error message when a transient failure occurs during execution of a nonidempotent step.

This issue was fixed in this PR for the attempt rollover step by implementation is still needed for attemptCallForceMerge, attemptNotificationStep, attemptShrinkStep, & attemptSnapshotStep as indicated by the TODOs I added on their class' isTranisentFailure method. You need to implement isTransientFailure for all of these classes in the same way I did for the attempt rollover step

How can one reproduce the bug?
Steps to reproduce the behavior:
The logic for the scenerio that creates the bug is in RolloverActionIT.test rollover detects transient failure and continues executing

After implementation of the TODOs, if you write a similar integration test on the other steps it should continue execution if a transient failure occured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ism action medium
Projects
Status: Todo
Development

No branches or pull requests

2 participants