Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue37 #854

Closed
wants to merge 79 commits into from

actually fixed commits now

565bf59
Select commit
Loading
Failed to load commit list.
Closed

Issue37 #854

actually fixed commits now
565bf59
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
DCO / DCO required action Jul 15, 2023 in 1s

DCO

There are 9 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~79 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin issue37

Summary

Commit sha: 85b9bc4, Author: Angie Zhang, Committer: GitHub; Can not find "Angie Zhang 98716549+Angie-Zhang@users.noreply.github.com", in ["Angie Zhang langelzh@amazon.com", "Angie Zhang langelzh@amazon.com"].
Commit sha: c0138c4, Author: Angie Zhang, Committer: GitHub; Can not find "Angie Zhang 98716549+Angie-Zhang@users.noreply.github.com", in ["Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com", "Petar Dzepina petar.dzepina@gmail.com"].
Commit sha: d9793ac, Author: Angie Zhang, Committer: GitHub; Can not find "Angie Zhang 98716549+Angie-Zhang@users.noreply.github.com", in ["Angie Zhang langelzh@amazon.com", "Angie Zhang langelzh@amazon.com", "Angie Zhang langelzh@amazon.com", "Angie Zhang langelzh@amazon.com", "Angie Zhang langelzh@amazon.com", "Angie Zhang langelzh@amazon.com"].
Commit sha: 86bdfac, Author: Ronnak Saxena, Committer: Ronnak Saxena; The sign-off is missing.
Commit sha: 5123890, Author: Ronnak Saxena, Committer: Ronnak Saxena; The sign-off is missing.
Commit sha: af10d48, Author: Ronnak Saxena, Committer: Ronnak Saxena; The sign-off is missing.
Commit sha: 565bf59, Author: Ronnak Saxena, Committer: Ronnak Saxena; The sign-off is missing.
Commit sha: 86339f9, Author: Yuye Zhu, Committer: GitHub; Can not find "Yuye Zhu yuyezhu@amazon.com", in ["yuye-aws yuyezhu@amazon.com", "yuye-aws yuyezhu@amazon.com", "yuye-aws yuyezhu@amazon.com", "yuye-aws yuyezhu@amazon.com"].
Commit sha: 94c48e9, Author: Zelin Hao, Committer: GitHub; Can not find "Zelin Hao 87548827+zelinh@users.noreply.github.com", in ["Zelin Hao zelinhao@amazon.com", "Zelin Hao zelinhao@amazon.com", "Zelin Hao zelinhao@amazon.com"].