Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Reverts Document Replication lock index setting #473

Merged
merged 1 commit into from
Aug 22, 2023
Merged

[Backport 2.x] Reverts Document Replication lock index setting #473

merged 1 commit into from
Aug 22, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 7021e39 from #472

@joshpalis @github-actions
Reverting temporary changes to enforce document replication on lock i…
d22fa2a 
…ndex now that SegRep supports retrieval by document ID (#472)

Signed-off-by: Joshua Palis <jpalis@amazon.com>
(cherry picked from commit 7021e39)
@joshpalis
Copy link
Member

Tagging related issue : #471

@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #473 (d22fa2a) into 2.x (cc39e3b) will not change coverage.
Report is 1 commits behind head on 2.x.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x     #473   +/-   ##
=========================================
  Coverage     29.19%   29.19%           
  Complexity       98       98           
=========================================
  Files            22       22           
  Lines          1185     1185           
  Branches        109      109           
=========================================
  Hits            346      346           
  Misses          818      818           
  Partials         21       21
Files Changed Coverage Δ
...scheduler/rest/action/RestGetJobDetailsAction.java 42.59% <ø> (ø)
...ch/jobscheduler/rest/action/RestGetLockAction.java 34.69% <ø> (ø)
...obscheduler/rest/action/RestReleaseLockAction.java 11.11% <ø> (ø)
...rg/opensearch/jobscheduler/sweeper/JobSweeper.java 39.74% <ø> (ø)
...duler/transport/response/JobParameterResponse.java 0.00% <ø> (ø)
...cheduler/transport/response/JobRunnerResponse.java 0.00% <ø> (ø)
...ensearch/jobscheduler/utils/JobDetailsService.java 2.57% <ø> (ø)

@dbwiddis dbwiddis merged commit 77bd862 into 2.x Aug 22, 2023
11 checks passed
@dbwiddis dbwiddis deleted the backport/backport-472-to-2.x branch August 22, 2023 23:22
@dbwiddis dbwiddis added the v2.10.0 Issues targeting release v2.10.0 label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@dreamer-89 dreamer-89 dreamer-89 approved these changes

@joshpalis joshpalis joshpalis approved these changes

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

@vibrantvarun vibrantvarun Awaiting requested review from vibrantvarun vibrantvarun is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

Assignees
No one assigned
Labels
v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshpalis @dbwiddis @dreamer-89