Removed publishPluginZipPublicationToMavenLocal from exclude list #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
owaiskazi19
requested review from
joshpalis,
saratvemulapalli,
dbwiddis,
kaituo,
vibrantvarun and
cwperks
as code owners
Signed-off-by: owaiskazi19 <owaiskazi19@gmail.com>
dbwiddis
approved these changes
Feb 9, 2024
|
Can you once test if this publishing the zip on all the places required on sonatype? I remember this a way to check on the machine as well. /opensearch-job-scheduler-spi |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=========================================
Coverage 29.17% 29.17%
Complexity 98 98
=========================================
Files 22 22
Lines 1186 1186
Branches 109 109
=========================================
Hits 346 346
Misses 819 819
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
Seen the artifacts in right place. But missing |
prudhvigodithi
requested changes
Feb 9, 2024
|
Verified the below with @vibrantvarun |
This is a PR to main, right? |
|
Me and @owaiskazi19 have tested the artifact publishing on the local machine. /opensearch-job-scheduler-spi jar gets published cc: @prudhvigodithi |
|
I think the artifact in .m2 path is missing because we do not have publishToMavenLocal in the maven-publish.yml |
|
@owaiskazi19 I have tested your changes against Before the change, In local maven ( After the change, In local maven ( |
This was referenced Feb 9, 2024
|
DO NOT MERGE THIS. Created #582 to copy the zips for now. |
Converted to draft just in case. |
|
Closing this PR in favor of #584. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed publishPluginZipPublicationToMavenLocal from exclude list
Issues Resolved
Coming from opensearch-project/skills#178 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.