Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Update developer guide to include M1 Setup #1284

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

ryanbogan
Copy link
Member

Description

Backport of #1222

Issues Resolved

#580

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@ryanbogan ryanbogan changed the title [Backport 2.x] [Backport 2.x] Update developer guide to include M1 Setup Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1284 (6229ef8) into 2.x (5e15d16) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1284      +/-   ##
============================================
+ Coverage     85.06%   85.12%   +0.06%     
  Complexity     1187     1187              
============================================
  Files           155      155              
  Lines          4881     4881              
  Branches        450      450              
============================================
+ Hits           4152     4155       +3     
+ Misses          530      527       -3     
  Partials        199      199              

see 1 file with indirect coverage changes

@naveentatikonda
Copy link
Member

@ryanbogan can we merge this PR?

@ryanbogan ryanbogan merged commit ee66aaa into 2.x Oct 30, 2023
74 of 76 checks passed
@ryanbogan ryanbogan deleted the backport/backport-1222-to-2.x branch October 30, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants