increase cluster node timeout value for time consuming test cases #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: will-hwang <sang7239@gmail.com>
will-hwang
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
5 tasks
junqiu-lei
added
the
backport 2.x
yizheliu-amazon
approved these changes
Jan 6, 2025
heemin32
approved these changes
Jan 6, 2025
junqiu-lei
approved these changes
Jan 6, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
) Signed-off-by: will-hwang <sang7239@gmail.com> (cherry picked from commit 8803377)
will-hwang
added a commit
to will-hwang/neural-search
that referenced
this pull request
Jan 8, 2025
…ases (opensearch-project#1063) (opensearch-project#1064)" This reverts commit 08ed333.
will-hwang
added a commit
to will-hwang/neural-search
that referenced
this pull request
Jan 8, 2025
…ases (opensearch-project#1063) (opensearch-project#1064)" This reverts commit 08ed333.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces a refactor of the code in
BaseNeuralSearchITto enable flexible timeout setting for cluster nodes, and increases the time out value from 60s to 90s for the below test cases:testBatchIngestion_SparseEncodingProcessor_E2EFlowtestTextImageEmbeddingProcessor_E2EFlowtestSparseEncodingProcessor_E2EFlowtestSemanticSearch_E2EFlowBased on the previous PRs (link), these test cases in BWC suite frequently failed with timeout, which requires manual re-run of the CI action
Related Issues
Resolves #1035 #981
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.