api changes for UI #1479
Closed
api changes for UI #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
YANG-DB
requested changes
Mar 23, 2023
There was a problem hiding this comment.
why do we need an integration-put ? can't we just use the integration-instance for put operation as-well ?
| @@ -446,21 +480,12 @@ paths: | |||
| content: | |||
| application/json: | |||
| schema: | |||
| $ref: '../../schema/system/integration-instance.schema' | |||
| $ref: '../../schema/system/integration-put.schema' | |||
There was a problem hiding this comment.
why do we need a dedicated resource for the put operation ? it is not a conventional REST operation
YANG-DB
added
documentation
YANG-DB
requested changes
Mar 30, 2023
There was a problem hiding this comment.
please remove this type - it is identical to the integration instance
derek-ho
commented
May 11, 2023
| - name: sso-logs-dashboard-new.ndjson | ||
| creationDate: "'2016-08-29T09:12:33.001Z'" | ||
| status: LOADED | ||
| examples: |
|
@derek-ho what steps do we need to do in order to get this revised and merged? We really should be freezing our data interfaces soon. |
|
Closing, as we went forward with frontend plugin design |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.