Add new script to fetch benchmark test-execution-id for baseline and contender #472
Conversation
rishabh6788
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya,
Divyaasm and
zelinh
as code owners
vars/getCompareBenchmarkIds.groovy
Outdated
| }' | ||
| """ | ||
|
|
||
| println("The curl command is:\n${curlCommand}") |
There was a problem hiding this comment.
Shall we remove this since it has risk of exposing the credentials?
There was a problem hiding this comment.
Removed, but don't think there is any risk of exposing credentials as jenkins masks all the values since it is used in the scope of withCredentials method.
Have tested and verified this already.
vars/getCompareBenchmarkIds.groovy
Outdated
| }' | ||
| """ | ||
|
|
||
| println("The curl command is:\n${curlCommand}") |
vars/getCompareBenchmarkIds.groovy
Outdated
| String contenderId = processQueryOutput(output) | ||
| return contenderId |
There was a problem hiding this comment.
Nit: Can simply return processQueryOutput(output)?
vars/getCompareBenchmarkIds.groovy
Outdated
|
|
||
| String output = sh(script: curlCommand, returnStdout: true).trim() | ||
|
|
||
| String baselineId = processQueryOutput(output) |
There was a problem hiding this comment.
Nit: Can simply return processQueryOutput(output)?
…contender Signed-off-by: Rishabh Singh <sngri@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
============================================
+ Coverage 84.26% 84.29% +0.03%
Complexity 80 80
============================================
Files 106 107 +1
Lines 521 522 +1
Branches 61 61
============================================
+ Hits 439 440 +1
Misses 26 26
Partials 56 56 ☔ View full report in Codecov by Sentry. |
|
Please make sure to rerun the autobump workflow after closing the old one. Thanks. |
|
Yes, I am waiting on a few PRs from @OVI3D0 for the same. |
Description
This PR adds a script to fetch
test-execution-idfor baseline and contender benchmark runs.The baseline runs are scheduled to run nightly and have following metadata attached to each metric record,
workload,cluster-configanddistribution-versionand the contender runs havepull_request_numbermetadata attached to its metrics for easy identification.The script uses these filters to fetch the latest
test-execution-idfor baseline and contender runs.These ids will later be used to run
comparecommand of opensearch-benchmark to fetch comparison results.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.