Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build failure library to use metrics data #515

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Oct 2, 2024

Description

This PR brings below changes:

  • Refactor OpenSearchMetricsQuery class to use any index for query and move it under utils package
  • Now instead of adding comments on the same issue, build failure issues will have updated issue body.
  • Add opensearch-distribution-build-results alias for opensearch-distribution-build-results-* indices
  • [Breaking] Refactor updateBuildFailureIssues library to use metrics data as the source of truth to get passing and failing components.
  • [Breaking] Rename UpdateBuildFailureIssues to updateBuildFailureIssues as all other libraries in the repo
  • [Breaking] Removed unused libraries related to build failure issues. (createBuildFailureGithubIssue.groovy and closeBuildSuccessGithubIssue.groovy)

Issues Resolved

Related opensearch-project/opensearch-build#5038

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…dFailureIssues library with new logic

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.46%. Comparing base (8a67658) to head (46ce7c0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tests/jenkins/TestComponentBuildStatus.groovy 71.42% 1 Missing and 3 partials ⚠️
src/jenkins/ComponentBuildStatus.groovy 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #515      +/-   ##
============================================
- Coverage     84.46%   84.46%   -0.01%     
- Complexity       80       87       +7     
============================================
  Files           108      109       +1     
  Lines           528      560      +32     
  Branches         61       64       +3     
============================================
+ Hits            446      473      +27     
- Misses           26       27       +1     
- Partials         56       60       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gaiksaya gaiksaya merged commit 87cf890 into opensearch-project:main Oct 7, 2024
9 checks passed
@gaiksaya gaiksaya deleted the buildNotification branch October 7, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants