Remove credentials dependency from build.gradle #534
Conversation
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya,
rishabh6788 and
Divyaasm
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
=========================================
Coverage 84.72% 84.72%
Complexity 105 105
=========================================
Files 115 115
Lines 648 648
Branches 71 71
=========================================
Hits 549 549
Misses 29 29
Partials 70 70 ☔ View full report in Codecov by Sentry. |
build.gradle
Outdated
| @@ -76,7 +76,7 @@ sharedLibrary { | |||
| dependency('org.jenkins-ci.plugins.workflow', 'workflow-multibranch', '2.26.1') | |||
| dependency('org.jenkins-ci.plugins', 'pipeline-input-step', '456.vd8a_957db_5b_e9') // https://repo.jenkins-ci.org/public/org/jenkins-ci/plugins/pipeline-input-step/ | |||
| dependency('org.jenkins-ci.plugins', 'script-security', '1229.v4880b_b_e905a_6') | |||
| dependency('org.jenkins-ci.plugins', 'credentials', '1112.vc87b_7a_3597f6') | |||
| dependency('org.jenkins-ci.plugins', 'credentials', '1381.v2c3a_12074da_b_') | |||
There was a problem hiding this comment.
Is it normal for such as big bump?
Also shall we keep the same version of this as the one on jenkins docker image?
cc: @gaiksaya Thanks.
There was a problem hiding this comment.
Would recommend removing the dependency from here. I believe it was added to resolve CVE.
There was a problem hiding this comment.
Just removed this dependency from the file. Please take another look. Thanks!
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
changed the title
Seems like it's failing again. I contacted Mend support on the same previous issue and they are investigating on the issue. |
Description
Remove explicit credentials dependency in the build.gradle file.
Issues Resolved
#518
#519
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.