Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: OpenSearch-Dashboards distribution builds are failing for RPM assemble #5099

Closed
gaiksaya opened this issue Oct 11, 2024 · 6 comments · Fixed by #5113
Closed

[Bug]: OpenSearch-Dashboards distribution builds are failing for RPM assemble #5099

gaiksaya opened this issue Oct 11, 2024 · 6 comments · Fixed by #5113
Assignees
Labels

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Oct 11, 2024

Describe the bug

See below build workflow runs:

Both workflows failed with below error:

Processing files: opensearch-dashboards-2.18.0-1.aarch64
error: File not found: /tmp/tmpns7bv2kd/BUILDROOT/opensearch-dashboards-2.18.0-1.aarch64/usr/share/opensearch-dashboards/.i18nrc.json

RPM build errors:
    File not found: /tmp/tmpns7bv2kd/BUILDROOT/opensearch-dashboards-2.18.0-1.aarch64/usr/share/opensearch-dashboards/.i18nrc.json
2024-10-10 02:27:03 INFO     Removing /tmp/tmpns7bv2kd
Traceback (most recent call last):
  File "/var/jenkins/workspace/distribution-build-opensearch-dashboards/./src/run_assemble.py", line 58, in <module>
    sys.exit(main())
  File "/var/jenkins/workspace/distribution-build-opensearch-dashboards/./src/run_assemble.py", line 49, in main
    bundle.package(output_dir)
  File "/var/jenkins/workspace/distribution-build-opensearch-dashboards/src/assemble_workflow/bundle.py", line 103, in package
    self.min_dist.build(self.bundle_recorder.package_name, dest)
  File "/var/jenkins/workspace/distribution-build-opensearch-dashboards/src/assemble_workflow/dist.py", line 85, in build
    self.__build__(name, dest)
  File "/var/jenkins/workspace/distribution-build-opensearch-dashboards/src/assemble_workflow/dist.py", line 136, in __build__
    BundleLinuxRpm(self.filename, self.path, self.min_path).build(name, dest, self.archive_path, self.build_cls)
  File "/var/jenkins/workspace/distribution-build-opensearch-dashboards/src/assemble_workflow/bundle_linux_rpm.py", line 95, in build
    subprocess.check_call(bundle_cmd, cwd=ext_dest, shell=True)
  File "/usr/lib64/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'rpmbuild -bb --define '_topdir /tmp/tmpns7bv2kd' --define '_version 2.18.0' --define '_architecture aarch64' opensearch-dashboards.rpm.spec' returned non-zero exit status 1.
script returned exit code 1

To reproduce

Re-run above workflows or try building opensearch-dashboards RPM distribution from source. Wiki

Expected behavior

Distribution builds should succeed.

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

@gaiksaya gaiksaya added bug Something isn't working untriaged Issues that have not yet been triaged labels Oct 11, 2024
@peterzhuamazon
Copy link
Member

Seems like they remove the i18n plugins?
Would need to take a look as it is expecting the file there.

Thanks.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Oct 14, 2024

This PR has moved the location of the i18n.json
opensearch-project/OpenSearch-Dashboards#8414

Seems like it is only backported to 2.x so 2.x and up.

@peterzhuamazon peterzhuamazon self-assigned this Oct 14, 2024
@peterzhuamazon peterzhuamazon added rpm Build Libraries & Interfaces and removed untriaged Issues that have not yet been triaged labels Oct 14, 2024
@peterzhuamazon
Copy link
Member

Issue identified, will PR tomorrow to fix this. Thanks.

@peterzhuamazon
Copy link
Member

More related: opensearch-project/OpenSearch-Dashboards#8424

@peterzhuamazon
Copy link
Member

This file is not included in the final bundle anymore.

@peterzhuamazon
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants