Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional cluster config support in OSD integTest #3590

Conversation

peterzhuamazon
Copy link
Member

Description

Add additional cluster config support in OSD integTest

Issues Resolved

#3589 partially
#3434

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@rishabh6788
Copy link
Collaborator

rishabh6788 commented Jun 1, 2023

LGTM.
If we have tests for LocalTestClusterOpenSearchDashboards can you add a test case for self.additional_cluster_config parameter being passed.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #3590 (1c82aa2) into main (a70172d) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3590      +/-   ##
==========================================
- Coverage   91.48%   91.45%   -0.04%     
==========================================
  Files         181      181              
  Lines        5369     5373       +4     
==========================================
+ Hits         4912     4914       +2     
- Misses        457      459       +2     
Impacted Files Coverage Δ
...teg_test/integ_test_suite_opensearch_dashboards.py 92.42% <33.33%> (-2.82%) ⬇️
...rkflow/integ_test/service_opensearch_dashboards.py 96.82% <100.00%> (+0.05%) ⬆️

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Jun 1, 2023

LGTM. If we have tests for LocalTestClusterOpenSearchDashboards can you add a test case for self.additional_cluster_config parameter being passed.

Added test.
Thanks.

@peterzhuamazon peterzhuamazon mentioned this pull request Jun 1, 2023
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants