Update ubuntu image chromium installation methods #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added
bug
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
42 tasks
bbarani
approved these changes
Jun 5, 2023
rishabh6788
approved these changes
Jun 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #3600 +/- ##
==========================================
- Coverage 91.49% 91.48% -0.02%
==========================================
Files 181 181
Lines 5376 5376
==========================================
- Hits 4919 4918 -1
- Misses 457 458 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update ubuntu image chromium installation methods.
In Ubuntu snap is required to install chromium correctly, where it is not easy to get running on docker.
Switch to https://github.com/saiarcot895/chromium-ubuntu-build to install non-snap version of chromium.
Issues Resolved
#3434
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.