Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fonts on windows docker image for chromium-based browser and lock docker version #4417

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Feb 6, 2024

Description

Install fonts on windows docker image for chromium-based browser and lock docker version

Issues Resolved

#4370
#4416
#4126

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon self-assigned this Feb 6, 2024
@peterzhuamazon peterzhuamazon changed the title Install fonts on windows docker image for chromium-based browser Install fonts on windows docker image for chromium-based browser and lock docker version Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6469398) 91.35% compared to head (d2e9209) 91.35%.

❗ Current head d2e9209 differs from pull request most recent head f7000ab. Consider uploading reports for the commit f7000ab to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4417   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         190      190           
  Lines        6197     6197           
=======================================
  Hits         5661     5661           
  Misses        536      536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit 7c1aec8 into opensearch-project:main Feb 6, 2024
10 checks passed
@peterzhuamazon peterzhuamazon deleted the win-integtest-2.12-3 branch February 6, 2024 22:17
@peterzhuamazon
Copy link
Member Author

@peterzhuamazon
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants