Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy all of the observability integrations from upstream #161

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Jun 11, 2024

Description

Coming from opensearch-project/dashboards-observability#1889, I went to copy the changes here and noticed that there's a large delta between this repo and the shipped integrations. This PR is a full clean copy from upstream, to get the repos back in sync.

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Jun 11, 2024

It looks like the bulk of the diff is removing stuff that exists extra here, are those extras being used somewhere/should we find a new location for them? Maybe it's worthwhile to split the integration directory from supplementary info directories if we just want to keep things in sync -- having parity in a specific directory will make the conversion to fully catalog-sourced integrations more seamless.

@YANG-DB
Copy link
Member

YANG-DB commented Jun 11, 2024

@Swiddis we actually need all the README files so that each integration will have its own document landing page

@Swiddis Swiddis marked this pull request as draft June 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants