Ensure packer to provision EC2 instance with imdsv2 enabled #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
requested review from
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi and
Divyaasm
as code owners
|
Tested on beta jenkins account and we do not need to rebuild, due to this will only affect the AMI build process, not AMI itself. Thanks. |
gaiksaya
approved these changes
Jul 10, 2024
Yes, have tested to build within a docker, and still runs fine as the connection is just initialized from docker -> EC2. |
|
Waiting for: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure packer to provision EC2 instance with imdsv2 enabled
Note that this will not make the AMI itself to be imdsv2 only
We currently still maintain the ability for AMI to be both imdsv1 and imdsv2, and use Jenkins EC2 plugin to enforce the imdsv2 during provision of agents.
Thanks.
Issues Resolved
#435
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.