Skip to content

Commit

Permalink
ism-plugin: fix tests (#1030)
Browse files Browse the repository at this point in the history
Change ...

  1. 'Close indices' to 'Close'
  2. 'Open indices' to 'Open'
  3. 'indices' to 'indexes'
  4. Sample slack webhook to meet current validation

... to match current tech writing guidelines.

Signed-off-by: Rohit Ashiwal <rashiwal@amazon.com>
  • Loading branch information
r1walz authored Feb 1, 2024
1 parent b5a0786 commit 10443bd
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ describe('Indices', () => {
.click();

// Check for close index modal
cy.contains('Close indices');
cy.contains('Close');

// Close confirm button should be disabled
cy.get('[data-test-subj="Close Confirm button"]').should(
Expand Down Expand Up @@ -525,7 +525,7 @@ describe('Indices', () => {
.click();

// Check for open index modal
cy.contains('Open indices');
cy.contains('Open');

cy.get('[data-test-subj="Open Confirm button"]').click();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ describe('Managed indices', () => {
});

// Confirm we got a remove policy toaster
cy.contains('Removed policy from 1 managed indices');
cy.contains('Removed policy from 1 managed indexes');

// Wait some time for remove policy to execute before reload
cy.wait(3000).reload();

// Confirm we are back to empty loading state, give 20 seconds as OSD takes a while to load
cy.contains('There are no existing managed indices.', { timeout: 20000 });
cy.contains('There are no existing managed indexes.', { timeout: 20000 });
});
});

Expand Down Expand Up @@ -123,7 +123,7 @@ describe('Managed indices', () => {
cy.get(`[data-test-subj="retryModalRetryButton"]`).click({ force: true });

// Confirm we got retry toaster
cy.contains('Retried 1 managed indices');
cy.contains('Retried 1 managed indexes');

// Reload the page
cy.reload();
Expand Down Expand Up @@ -249,10 +249,10 @@ describe('Managed indices', () => {
});

// Confirm we got the change policy toaster
cy.contains('Changed policy on 1 indices');
cy.contains('Changed policy on 1 indexes');

// Click back to Managed Indices page by clicking "Managed indices" breadcrumb
cy.contains('Policy managed indices').click();
cy.contains('Policy managed indexes').click();

// Speed up execution of managed index
cy.updateManagedIndexConfigStartTime(SAMPLE_INDEX);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('NotificationSettings', () => {
config_type: 'slack',
is_enabled: true,
slack: {
url: 'https://sample-slack-webhook',
url: 'https://hooks.slack.com/services/sample-slack-webhook',
},
},
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ describe('Rollups', () => {
cy.get('button').contains('Next').click({ force: true });

// Confirm that we got to step 4 of creation page
cy.contains('Job name and indices');
cy.contains('Job name and indexes');

// Click the create button
cy.get('button').contains('Create').click({ force: true });
Expand Down

0 comments on commit 10443bd

Please sign in to comment.