Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): paths-filter error on push event #1017

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Jan 30, 2024

Resolved
#993
#1108

Removed dorny/paths-filter action and use GitHub workflow builtin path filter

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruanyl
Copy link
Member Author

ruanyl commented Feb 2, 2024

This can be replaced with https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/manifests.yml#L6-L9 I think.

Nice! Thanks for the suggestion, will try that github flow builtin solution

run checkout action before paths-filter

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl force-pushed the fix-bundle-snapshot-workflow branch from 87ca867 to e38a899 Compare March 27, 2024 06:13
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for resolving #1108 casually.

@ruanyl ruanyl merged commit 9f0d25d into opensearch-project:main Mar 28, 2024
36 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 28, 2024
refactor to use Github action builtin path filter

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 9f0d25d)
ruanyl added a commit that referenced this pull request Mar 28, 2024
refactor to use Github action builtin path filter

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 9f0d25d)

Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
LDrago27 pushed a commit to LDrago27/opensearch-dashboards-functional-test that referenced this pull request May 3, 2024
)

refactor to use Github action builtin path filter

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants