Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add functional test for datasources at observability dashboards plugin #1024

Merged

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Jan 30, 2024

Description

Add functional test for datasources at observability dashboards plugin

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-project#987)

* Add functional test for datasources at observability dashboards plugin

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Extend the header locating to 2 mins

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix lint

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@ruanyl
Copy link
Member

ruanyl commented Jan 31, 2024

@RyanL1997 I fixed an testing running forever issue recently for observability, and I noticed two tests are failing for 7_datasources_dashboard.spec.js: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7712151209/job/21019043851?pr=1023

Could you take a look?

7_datasources_dashboard.spec.js.mp4

@Hailong-am
Copy link
Collaborator

I fixed an testing running forever issue recently for observability,

@ruanyl can you check https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7720266678/job/21044878653?pr=1024, it still run forever?

@ruanyl
Copy link
Member

ruanyl commented Jan 31, 2024

I fixed an testing running forever issue recently for observability,

@ruanyl can you check https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/7720266678/job/21044878653?pr=1024, it still run forever?

The PR hasn't merged #1023

@RyanL1997
Copy link
Contributor Author

@ruanyl I can take a look on this. This is due to the enable of security, so that the url has the slug of security tenant.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@RyanL1997
Copy link
Contributor Author

Hi @ruanyl, thx for the reminder. I have fixed the issue. Could you please verify that?

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@ruanyl
Copy link
Member

ruanyl commented Feb 1, 2024

@RyanL1997 thanks for the fix! Btw, maybe you want to create another PR to apply the same fix to main :)

@ruanyl ruanyl merged commit ea15869 into opensearch-project:2.x Feb 1, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants