Notebooks add index refresh, remove SQL check in paragraph #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
wanglam
reviewed
Feb 6, 2024
| cy.reload(); | ||
| // Force refresh the observablity index and reload page to load notebooks. | ||
| if (loadedOnce === 0) { | ||
| cy.request({ |
There was a problem hiding this comment.
It seems this refresh only execute once after moveToNotebookHome call. Is this by intentionally?
There was a problem hiding this comment.
Yes, once the refresh is complete then new notebook is loaded. Internally, Observability index notebook doc Id in lucene is committed after creation and refresh and doesn't need a refresh for document updates.
ruanyl
approved these changes
Feb 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit f45cdf7)
ruanyl
pushed a commit
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notebooks add index refresh, remove SQL check in paragraph
Issues Resolved
#897
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.