-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed failed discover app shared links tests #1079
fixed failed discover app shared links tests #1079
Conversation
1. refactor so that each test case is indepent from each other 2. use decodeURI to make url consistent so that the url matches Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@abbyhu2000 would be nice if you could take a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the tests!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1079-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3a98fe6bd54d4d35e8f43110fe55c0d57dc1e873
# Push it to GitHub
git push --set-upstream origin backport/backport-1079-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
1. refactor so that each test case is indepent from each other 2. use decodeURI to make url consistent so that the url matches Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Needs to revert this PR because adding Alternatively, we should skip the cypress tests when security is enabled: |
Description
this PR fixed the 3 failed tests of
cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/shared_links.spec.js
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.