Fix in-context reporting tests #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
|
Will also need to forward-port to 2.x and main, starting here since FTR is failing in RC generation. |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
88 tasks
kavilla
approved these changes
Feb 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Fix in-context report tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch to checking for success toast Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix syntax Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 651db8d)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Fix in-context report tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch to checking for success toast Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix syntax Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 651db8d)
CCongWang
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Fix in-context report tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch to checking for success toast Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix syntax Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 651db8d) Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
CCongWang
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Fix in-context report tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch to checking for success toast Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix syntax Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 651db8d) Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When checking for a reporting download being triggered, the tests are waiting for a loading screen. This causes test failures if the download happens faster than React renders. In one test run, the test failed when the API returned in 18 ms (whereas a passing test in the same run had a return time of 224 ms). This PR updates the tests to instead check for the success toast.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.