Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assistant failed cases because of change of ml-commons #1110

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

SuZhou-Joe
Copy link
Member

Description

ml-commons changes the prompt when using tool in agent framework

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for helping fix this

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit 60e2503 into opensearch-project:main Feb 19, 2024
39 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 19, 2024
* feat: change matching prompt string

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add file

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 60e2503)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 19, 2024
* feat: change matching prompt string

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add file

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 60e2503)
SuZhou-Joe added a commit that referenced this pull request Feb 19, 2024
…1111)

* feat: change matching prompt string

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add file

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 60e2503)

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit that referenced this pull request Feb 19, 2024
…1112)

* feat: change matching prompt string

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add file

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: traces update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 60e2503)

Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants