[Discover] set local storage directly for large string spec #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other test utilize the helper function and not seeing the particular need for this test to ensure it switches. But by doing this avoid whatever is taking focus of the popover that lets the test first click the button but before cypress test runner clicks the switch. Issue: n/a Signed-off-by: Kawika Avilla <avillk@amazon.com>
kavilla
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Hailong-am
approved these changes
Mar 26, 2024
ashwin-pc
approved these changes
Mar 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Other test utilize the helper function and not seeing the particular need for this test to ensure it switches. But by doing this avoid whatever is taking focus of the popover that lets the test first click the button but before cypress test runner clicks the switch. Issue: n/a Signed-off-by: Kawika Avilla <avillk@amazon.com> Co-authored-by: Kawika Avilla <avillk@amazon.com> (cherry picked from commit c17e560)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Other test utilize the helper function and not seeing the particular need for this test to ensure it switches. But by doing this avoid whatever is taking focus of the popover that lets the test first click the button but before cypress test runner clicks the switch. Issue: n/a Signed-off-by: Kawika Avilla <avillk@amazon.com> Co-authored-by: Kawika Avilla <avillk@amazon.com> (cherry picked from commit c17e560)
kavilla
added a commit
that referenced
this pull request
Mar 26, 2024
…1176) Other test utilize the helper function and not seeing the particular need for this test to ensure it switches. But by doing this avoid whatever is taking focus of the popover that lets the test first click the button but before cypress test runner clicks the switch. Issue: n/a Signed-off-by: Kawika Avilla <avillk@amazon.com> Co-authored-by: Kawika Avilla <avillk@amazon.com> (cherry picked from commit c17e560) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Mar 26, 2024
…1175) Other test utilize the helper function and not seeing the particular need for this test to ensure it switches. But by doing this avoid whatever is taking focus of the popover that lets the test first click the button but before cypress test runner clicks the switch. Issue: n/a Signed-off-by: Kawika Avilla <avillk@amazon.com> Co-authored-by: Kawika Avilla <avillk@amazon.com> (cherry picked from commit c17e560) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…ch-project#1170) Other test utilize the helper function and not seeing the particular need for this test to ensure it switches. But by doing this avoid whatever is taking focus of the popover that lets the test first click the button but before cypress test runner clicks the switch. Issue: n/a Signed-off-by: Kawika Avilla <avillk@amazon.com> Co-authored-by: Kawika Avilla <avillk@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other test utilize the helper function and not seeing the particular need for this test to ensure it switches. But by doing this avoid whatever is taking focus of the popover that lets the test first click the button but before cypress test runner clicks the switch.
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.