[Backport 2.x] #3530 enhance sanity testing framework #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
kavilla
approved these changes
Apr 2, 2024
|
I'll defer to another maintainer to merge this in. The original PR doesn't do clean up and its from a while ago but I think it should be address in a follow up PR for someone who has the chance. |
|
the sanity_tests.spec.js still fails, I'd prefer we fixing the failed cases in this PR if no following PR already raised. |
|
@kavilla The new added test cases failed, could you please take a look here? |
SuZhou-Joe
force-pushed
the
backport/backport-958-to-2.x
branch
from
56b4d74
to
3fe0154
Compare
opensearch-trigger-bot
bot
requested review from
tianleh,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh and
prudhvigodithi
as code owners
SuZhou-Joe
force-pushed
the
backport/backport-958-to-2.x
branch
from
3fe0154
to
e61c346
Compare
* initial skeleton Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * first two sections Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * index pattern creation Signed-off-by: Sam <samuel.costa@eliatra.com> * Bug Fixes Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Cleanup Signed-off-by: Sam <samuel.costa@eliatra.com> * Refactor Signed-off-by: Sam <samuel.costa@eliatra.com> * Comment/ Extra line removal Signed-off-by: Sam <samuel.costa@eliatra.com> * Using loadSampleData command instead of custom method. Check if pattern was acually created Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Sam <samuel.costa@eliatra.com> (cherry picked from commit e1e0716)
SuZhou-Joe
force-pushed
the
backport/backport-958-to-2.x
branch
from
e61c346
to
86cf38d
Compare
|
No update for 3 months and rerun the CI still failed, close the PR. Please feel free to open if any update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e1e0716 from #958