[OSD] Sanitize copied share-link before validating #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
kavilla
approved these changes
Apr 9, 2024
Hailong-am
approved these changes
Apr 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 9b3878f)
Hailong-am
pushed a commit
that referenced
this pull request
Apr 11, 2024
LDrago27
pushed a commit
to LDrago27/opensearch-dashboards-functional-test
that referenced
this pull request
May 3, 2024
…t#1209) Signed-off-by: Miki <miki@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A copied snapshot URL included
security_tenantwhen security plugin was enabled and multitenancy was configured. This change sanitizes the copied URL before asserting to make the tests work correctly with and without security and multitenancy.Issues Resolved
Fixes opensearch-project/OpenSearch-Dashboards#6373
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.