[Backport 1.2] added fix for gantt-charts test for different timezones #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
changed the title
kavilla
reviewed
Sep 5, 2023
| @@ -5,8 +5,12 @@ | |||
|
|
|||
| /// <reference types="cypress" /> | |||
|
|
|||
| import customParseFormat from 'dayjs/plugin/customParseFormat'; | |||
| import dayjs from 'dayjs'; | |||
There was a problem hiding this comment.
I don't see this installed is it included in another dependency?
There was a problem hiding this comment.
True, We'll update the PR to use moment as mentioned here: #515. Thanks for the catch.
There was a problem hiding this comment.
Has been updated
There was a problem hiding this comment.
@kavilla we updated both the PRs to use moment js
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
kavilla
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix gantt-charts test for different timezones
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.