When a user has no roles, logout on button click

[leanneeliatra]

Description

Cypress tests for testing the no role button. On click, the user should be logged out.
opensearch-project/security-dashboards-plugin#1564

Issues Resolved

opensearch-project/security-dashboards-plugin#1564

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[kavilla]

@leanneeliatra looks like changes were requested on the original PR, should that be addressed here too?

[leanneeliatra]

@leanneeliatra looks like changes were requested on the original PR, should that be addressed here too?

Hi @kavilla thanks for the comment, the outstanding comment referenced the integration tests which are here now. I have requested a re-review so hopefully that's it! Thanks. If you were referring to something else please let me know but everything is addressed on the original PR now.

[derek-ho]

May need to change the button text here as well if that is done

[leanneeliatra]

May need to change the button text here as well if that is done

That's complete thanks.

[leanneeliatra]

@ruanyl @wanglam @Hailong-am @raintygao could the work in this MR please be reviewed, I have been in discussions to get the bug change itself over the line and when that is ready, I don't want the test to fall behind! If it could be reviewed and ready that would be great, thank you.

[Hailong-am]

@leanneeliatra would you mind fix the lint check https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/6470978871/job/17568385980?pr=830

[leanneeliatra]

@leanneeliatra would you mind fix the lint check https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/6470978871/job/17568385980?pr=830

I was having issues doing this change locally yesterday, then I was getting 347 linting errors on other files. I made the change by editing the file here, in GitHub. If you have any advice about this please share.

Thanks @Hailong-am. The lint fix is now complete.

[leanneeliatra]

@RyanL1997 was going to have a look at the cypress tests for me (thank you :) )

[leanneeliatra]

I'm not sure if I should be requesting reviews in the meantime, if all the checks aren't passed but in case it is okay to proceed (let me know if I should wait) can I please get a review @wanglam, @raintygao, @Hailong-am

[kavilla]

@leanneeliatra ive been pulling stuff down and verifying against a targetted release candidate as i still need to fix the ci here.

In the meantime can you post screen shots of these test passing and what is ran against? Also could post a screen shot of the dashboard sanity tests result as it will help verify this PR doesnt interfer with other tests.

This will help other maintainers with velocity

[leanneeliatra]

In the meantime can you post screen shots of these test passing and what is ran against? Also could post a screen shot of the dashboard sanity tests result as it will help verify this PR doesnt interfer with other tests.

For sure thanks @kavilla and thanks very much for checking this for me too.
I will add the test images.
For this request: Also could post a screen shot of the dashboard sanity tests result as it will help verify this PR doesn't interfere with other tests. I'm not certain what tests you are referring to here/where to run them please.

[leanneeliatra]

@kavilla I ran the test locally & am attaching screenshots:
Testing the changes and tests locally.
repo: opensearch-dashboards-functional-test
branch: leanneeliatra:missing-roles-button-tests
repo: security-dashboards-plugin
branch: leanneeliatra:2.8

Hopefully that's okay.

And can you please clarify which tests are the dashboard sanity tests and where I can run them please.

[leanneeliatra]

Are there remaining tests needed here from my end? I've added the passing cypress tests locally - perhaps this is enough.

Would it also be possible to get the remaining review if all is okay now please @Hailong-am Thanks a million for all your help.

[leanneeliatra]

The fix itself has now been merged opensearch-project/security-dashboards-plugin#1564
If the associated tests (this MR) could be reviewed and merged that would be great. The faling cypress test check above is due to cypress itself, the successfully running local test can be seen in a screenshot above.

Can this be merged please? @ruanyl could you confirm that for me please? I seem to have 2 reviews, yourself and @derek-ho, but I still need one more as only one of these is registering. Is that correct? Thanks.

[ruanyl]

@leanneeliatra I cannot perform merge right now, still need one more approval.

[leanneeliatra]

Thank you for checking this @ruanyl , I am requesting the last review via slack and PR.

The failing cypress test check above is due to cypress itself, the successfully running local test can be seen in a screenshot above.

The associated bug fix is merged, can I please get a final review of the tests (this PR). Thanks very much. cc @Hailong-am , @xluo-aws , @SuZhou-Joe