[Alerting 2.x] Override element covered check for name input in Composite monitor creation #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
1 task
kavilla
pushed a commit
that referenced
this pull request
Sep 18, 2023
When selecting delegate monitors for composite monitor creation, we are typing in the combo box div element which is throwing invalid typing element error. This PR fixes that by selecting the child input element instead. This change is already part of #866 for 2.x Issues Resolved: opensearch-project/alerting-dashboards-plugin#728 Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
|
Should this ported to |
ruanyl
reviewed
Sep 19, 2023
|
|
||
| // Select associated monitors | ||
| cy.get('[data-test-subj="monitors_list_0"]').type('monitorOne', { | ||
| cy.get('[id="associatedMonitorsList_0"]').type('monitorOne', { |
There was a problem hiding this comment.
Q: I'm curious why change from test id to element id? How will that mitigate the flaky test?
There was a problem hiding this comment.
This change is for - #872
Basically, we should type inside a valid input element. The test id was selecting the parent div, so changed it to use the id which selects the inner input element
There was a problem hiding this comment.
ah in the future, @ruanyl has a great point. You can still get the data subject and then get the id contained with that data test subject.
In this situation is seems like [id] is more or less in the structure of a data test subj? Perhaps to keep things similar throughout the project covert that id to data-test-subj?
amsiglan
added a commit
to amsiglan/opensearch-dashboards-functional-test
that referenced
this pull request
Sep 19, 2023
When selecting delegate monitors for composite monitor creation, we are typing in the combo box div element which is throwing invalid typing element error. This PR fixes that by selecting the child input element instead. This change is already part of opensearch-project#866 for 2.x Issues Resolved: opensearch-project/alerting-dashboards-plugin#728 Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Created PR #880 to update all alerting tests in main |
kavilla
approved these changes
Sep 25, 2023
kavilla
pushed a commit
that referenced
this pull request
Oct 6, 2023
* forcing name typing (#865) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * [Alerting] use input element for typing (#872) When selecting delegate monitors for composite monitor creation, we are typing in the combo box div element which is throwing invalid typing element error. This PR fixes that by selecting the child input element instead. This change is already part of #866 for 2.x Issues Resolved: opensearch-project/alerting-dashboards-plugin#728 Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * wait before checking update status Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are seeing flaky behavior when creating composite monitor. The name input element is sometimes not in view which prevents cypress from typing the name. Since this behavior won't happen when a user is creating the monitor it is safe to force the typing in the name element and the monitor selector elements.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.