Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cigroup for cypress workflow #917

Closed
wants to merge 31 commits into from
Closed

Add cigroup for cypress workflow #917

wants to merge 31 commits into from

Conversation

abbyhu2000
Copy link
Member

Description

Add CiGroup to improve workflow.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

abbyhu2000 and others added 30 commits October 10, 2023 14:39
@abbyhu2000
first tests
87717b5 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
more tests
f1631ef 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
more tests opensearch-project#3
5fcad1d 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
more tests 4
1f9f519 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
down arrow enter
00ee618 
Signed-off-by: Kawika Avilla <avillk@amazon.com>
@abbyhu2000
fix lint
a9c5a49 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
finish discover tests
bb946ed 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
retest first 5 test files
bf0719a 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
retest the next 6 test files
f4372e5 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
retest the rest of tests
9040440 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
finish shared link
6499f19 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
saved query tests
95d06c8 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fix save query tests
b6027ab 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fixing typo
c47b4b3 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
address comments
0ff5ac0 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
field_data_tests
9437b9c 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
removing skip data-share-item
bd94b6e 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
cleanup and optimize uploading data
9da763e 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fix bugs
6dd76e9 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fix changes to the latest main
6e6675a 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
unchange the package.json
4f6de1c 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fix error test
cc237fc 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
update test library tar file
7509245 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fix linter error in package.lock
ef912d6 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fix error on github ci
f4d5f90 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
add some skip tests due to flakiness
62b34c0 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fix ci opensearch-project#1
6dda269 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
fix shared_link
192828d 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
clear index pattern
c31bebd 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
remove unnecessary import
ae461ca 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000
add cigroups for cypress tests
8b75548 
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
SuZhou-Joe
SuZhou-Joe reviewed Oct 11, 2023
View reviewed changes
yarn-error.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be pushed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

SuZhou-Joe
SuZhou-Joe reviewed Oct 11, 2023
View reviewed changes
package.json
Comment on lines +28 to +36
"osd:ciGroup1": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/*.js'\"",
"osd:ciGroup2": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/vis_type_table/*.js'\"",
"osd:ciGroup3": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/vis-augmenter/*.js'\"",
"osd:ciGroup4": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_sample_data_with_datasource_spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/dashboard_sanity_test_spec.js'\"",
"osd:ciGroup5": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/datasource-management-plugin/*.js'\"",
"osd:ciGroup6": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/date_nanos_mixed.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/date_nanos.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover_histogram.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/discover.spec.js'\"",
"osd:ciGroup7": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/doc_navigation.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/doc_table.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/errors.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/field_data.spec.js'\"",
"osd:ciGroup8": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/field_visualize.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/filter_editor.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/index_pattern_with_encoded_id.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/index_pattern_without_field.spec.js'\"",
"osd:ciGroup9": "echo \"--spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/inspector.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/large_string.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/saved_queries.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/shared_links.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/sidebar.spec.js, cypress/integration/core-opensearch-dashboards/opensearch-dashboards/apps/data_explorer/source_filter.spec.js'\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move test cases under directory like ci-group{number} so that we won't need to add such a huge scripts in package.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will close this PR since i added the commit in PR #862.

Also shortened the scripts.

@abbyhu2000 abbyhu2000 closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe left review comments

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbyhu2000 @SuZhou-Joe