Fix share link for 2.x branch #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
abbyhu2000
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
kavilla
approved these changes
Oct 19, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Because of opensearch-project/OpenSearch-Dashboards#5095, the URL parsing is handled differently on main branch and 2.x branch. Therefore, this cypress test on 2.x branch needs to be modified. Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 518ce68)
kavilla
pushed a commit
that referenced
this pull request
Oct 19, 2023
Because of opensearch-project/OpenSearch-Dashboards#5095, the URL parsing is handled differently on main branch and 2.x branch. Therefore, this cypress test on 2.x branch needs to be modified. Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 518ce68) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix share link of save search for 2.x branch.
Issues Resolved
Because of opensearch-project/OpenSearch-Dashboards#5095, the URL parsing is handled differently on main branch and 2.x branch. Therefore, this cypress test on 2.x branch needs to be modified.