add admin credentials for regular release sign-off workflow #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl and
raintygao
as code owners
|
Seems related tests do not get ran, can we manually run these test to see if OSD bootstraps successfully under new script? |
|
@SuZhou-Joe Here is a workflow details in my own repo: https://github.com/wanglam/opensearch-dashboards-functional-test/actions/runs/7485549958/job/20374187050. It based 488cba3. |
derek-ho
approved these changes
Jan 12, 2024
Hailong-am
approved these changes
Jan 15, 2024
ruanyl
approved these changes
Jan 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 2354122)
wanglam
added a commit
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Run OpenSearch-Dashboards servertask was failed in the regular release sign-off workflow, the OSD API status checker missing required credentials and respond 401 error.Since the OpenSearch was run with security enabled, we need to pass the admin credentials to the
curlcommand.This PR add
-u admin:${{ env.OPENSEARCH_INITIAL_ADMIN_PASSWORD }}to thecurlcall for all release sign-off workflows.Issues Resolved
#985
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.