Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add functional test for datasources at observability dashboards plugin #998

Closed
wants to merge 2 commits into from
Closed

[Backport 2.x] Add functional test for datasources at observability dashboards plugin #998

wants to merge 2 commits into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8cd68dc from #987

@RyanL1997 @github-actions
Add functional test for datasources at observability dashboards plugin (
5e6eaba 
#987)

* Add functional test for datasources at observability dashboards plugin

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Extend the header locating to 2 mins

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix lint

Signed-off-by: Ryan Liang <jiallian@amazon.com>

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
(cherry picked from commit 8cd68dc)
Hailong-am
Hailong-am previously approved these changes Jan 15, 2024
View reviewed changes
@Hailong-am Hailong-am dismissed their stale review January 15, 2024 03:59

need fix DCO

@RyanL1997
Copy link
Contributor

RyanL1997 commented Jan 19, 2024 •
edited
Loading

Hi @Hailong-am, I think we need to by pass DCO for backport:

Commit sha: [5e6eaba](https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/998/commits/5e6eaba4683d28ecd0b4c3392faaccf59dae5729), 
Author: Jialiang Liang, Committer: github-actions[bot]; 
Can not find "Jialiang Liang [109499885+RyanL1997@users.noreply.github.com](mailto:109499885+RyanL1997@users.noreply.github.com)", 
in ["Ryan Liang [jiallian@amazon.com](mailto:jiallian@amazon.com)", "Ryan Liang [jiallian@amazon.com](mailto:jiallian@amazon.com)", "Ryan Liang [jiallian@amazon.com](mailto:jiallian@amazon.com)", "Ryan Liang [jiallian@amazon.com](mailto:jiallian@amazon.com)"].

It was expecting the bot's generated profile instead of my correct email address.

@Hailong-am
Copy link
Collaborator

Hi @Hailong-am, I think we need to by pass DCO for backport:

Commit sha: [5e6eaba](https://github.com/opensearch-project/opensearch-dashboards-functional-test/pull/998/commits/5e6eaba4683d28ecd0b4c3392faaccf59dae5729), 
Author: Jialiang Liang, Committer: github-actions[bot]; 
Can not find "Jialiang Liang [109499885+RyanL1997@users.noreply.github.com](mailto:109499885+RyanL1997@users.noreply.github.com)", 
in ["Ryan Liang [jiallian@amazon.com](mailto:jiallian@amazon.com)", "Ryan Liang [jiallian@amazon.com](mailto:jiallian@amazon.com)", "Ryan Liang [jiallian@amazon.com](mailto:jiallian@amazon.com)", "Ryan Liang [jiallian@amazon.com](mailto:jiallian@amazon.com)"].

It was expecting the bot's generated profile instead of my correct email address.

can you check Keep my email addresses private in page https://github.com/settings/emails? if that checkbox is checked, there will have similar issue in future backport

@Hailong-am
Copy link
Collaborator

@RyanL1997 would you mind do manual backport and close this one?

@RyanL1997
Copy link
Contributor

@Hailong-am , Yes, I have unchecked the box. Can we re-run it again? And if it doesn't work, I will manually backport it.

@Hailong-am
Copy link
Collaborator

@Hailong-am , Yes, I have unchecked the box. Can we re-run it again? And if it doesn't work, I will manually backport it.

re-run should not work, as the commit has not change.

@RyanL1997 RyanL1997 mentioned this pull request Jan 30, 2024
Merged
1 task
@RyanL1997
Copy link
Contributor

RyanL1997 commented Jan 30, 2024 •
edited
Loading

@Hailong-am Cloud you plz close this one due to the open of #1024

@ruanyl ruanyl closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am left review comments

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanL1997 @Hailong-am @ruanyl