-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add functional test for datasources at observability dashboards plugin #998
Conversation
#987) * Add functional test for datasources at observability dashboards plugin Signed-off-by: Ryan Liang <jiallian@amazon.com> * Extend the header locating to 2 mins Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix lint Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 8cd68dc)
Hi @Hailong-am, I think we need to by pass DCO for backport:
It was expecting the bot's generated profile instead of my correct email address. |
can you check |
@RyanL1997 would you mind do manual backport and close this one? |
@Hailong-am , Yes, I have unchecked the box. Can we re-run it again? And if it doesn't work, I will manually backport it. |
re-run should not work, as the commit has not change. |
@Hailong-am Cloud you plz close this one due to the open of #1024 |
Backport 8cd68dc from #987