[Backport 2.x] Recreate or wrap exceptions thrown by async transport implementations to preserve caller stack traces #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… to preserve caller stack traces (#656) * wrap exceptions thrown by async transport implementations in IOException Signed-off-by: Andrew Parmet <andrew@parmet.com> * license headers Signed-off-by: Andrew Parmet <andrew@parmet.com> * changelog Signed-off-by: Andrew Parmet <andrew@parmet.com> * tolerate null causes Signed-off-by: Andrew Parmet <andrew@parmet.com> * fix tests Signed-off-by: Andrew Parmet <andrew@parmet.com> * remove print Signed-off-by: Andrew Parmet <andrew@parmet.com> * one more license header Signed-off-by: Andrew Parmet <andrew@parmet.com> * fix last non-aws test Signed-off-by: Andrew Parmet <andrew@parmet.com> * use multicatch to restrict caught exceptions Signed-off-by: Andrew Parmet <andrew@parmet.com> * Replicate the RestClient exception wrapping for async invocation flow Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * replicate hc5 exception extraction strategy in aws transport Signed-off-by: Andrew Parmet <andrew@parmet.com> * move other tests Signed-off-by: Andrew Parmet <andrew@parmet.com> * lint Signed-off-by: Andrew Parmet <andrew@parmet.com> * delete aws test for now; add support for OpenSearchClientException Signed-off-by: Andrew Parmet <andrew@parmet.com> * reintroduce an aws test, sadly, not extending the abstract case Signed-off-by: Andrew Parmet <andrew@parmet.com> * java 8 Signed-off-by: Andrew Parmet <andrew@parmet.com> * replicate ISE Signed-off-by: Andrew Parmet <andrew@parmet.com> * poke Signed-off-by: Andrew Parmet <andrew@parmet.com> * handle some netty-specific channel exceptions Signed-off-by: Andrew Parmet <andrew@parmet.com> * poke Signed-off-by: Andrew Parmet <andrew@parmet.com> * nevermind netty Signed-off-by: Andrew Parmet <andrew@parmet.com> * io before rt Signed-off-by: Andrew Parmet <andrew@parmet.com> * no hc5 Signed-off-by: Andrew Parmet <andrew@parmet.com> --------- Signed-off-by: Andrew Parmet <andrew@parmet.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit db50b7d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
Bukhtawar,
dblock,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
approved these changes
May 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport db50b7d from #656.