Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added size attribute to MultiTermsAggregation #614

Closed
wants to merge 5 commits into from
Closed

Added size attribute to MultiTermsAggregation #614

wants to merge 5 commits into from

Conversation

fabiankopatschek
Copy link
Contributor

Description

Added size attribute to MultiTermsAggregation to retreive other hit sizes than the default value of the attribute.
Code for the added attribute was taken from TermsAggregation class.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Code for size Attribute is analog to TermsAggregation

Signed-off-by: Fabian Kopatschek <fabian.kopatschek@yahoo.de>
Signed-off-by: Fabian Kopatschek <fabian.kopatschek@yahoo.de>
@fabiankopatschek fabiankopatschek changed the title 2.x Added size attribute to MultiTermsAggregation Sep 4, 2023
@reta
Copy link
Collaborator

reta commented Sep 5, 2023

Thanks for contribution @fabiankopatschek , could you please add a test cases under AbstractAggregationRequestIT? Thank you.

Signed-off-by: Fabian Kopatschek <fabian.kopatschek@yahoo.de>
@dblock
Copy link
Member

dblock commented Sep 5, 2023

Also this should go against main, and we can backport it after we're good there.

@fabiankopatschek
Copy link
Contributor Author

Thanks for contribution @fabiankopatschek , could you please add a test cases under AbstractAggregationRequestIT? Thank you.

I really would like to add a test case. But unfortunately i'm not able to run the integration tests.
31 tests completed, 24 failed, 7 skipped

The AggregationRequestIT for example failes with this message:

java.lang.RuntimeException: found jar hell in test classpath
at org.opensearch.bootstrap.BootstrapForTesting.(BootstrapForTesting.java:118)
...

Any tips on how to fix this?

@reta
Copy link
Collaborator

reta commented Sep 5, 2023

Any tips on how to fix this?

Are you running with Eclipse? Or gradle?

@fabiankopatschek
Copy link
Contributor Author

Any tips on how to fix this?

Are you running with Eclipse? Or gradle?

I'm running the tests in the shell with gradle.
I've noticed that the integration test for this MR is having the same trouble.
I encounter the same problems with the main branch as well without any changes from me.

@reta
Copy link
Collaborator

reta commented Sep 6, 2023

I've noticed that the integration test for this MR is having the same trouble.

You are very right, the issue seems to be caused by latest software.amazon.awssdk 2.20.141 (which is imported using version range). Created an issue for it here #615

@fabiankopatschek
Copy link
Contributor Author

I migrated the code changes to the main branch as dblock suggested.
I also added an Integration Test as reta suggested.
There is a new pull request #627 for the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants