Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't over-allocate in HeapBufferedAsyncEntityConsumer in order to consume the response #620

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Sep 12, 2023

Description

Don't over-allocate in HeapBufferedAsyncEntityConsumer in order to consume the response

Issues Resolved

Backport of opensearch-project/OpenSearch#9993, closes #619

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Sep 12, 2023

Needs #616 to fix the checks first ...

@dblock
Copy link
Member

dblock commented Sep 13, 2023

Needs #616 to fix the checks first ...

Merged that, rebase?

dblock
dblock previously approved these changes Sep 13, 2023
…nsume the response

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@VachaShah VachaShah merged commit 86b6988 into opensearch-project:main Sep 14, 2023
30 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Sep 15, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-620-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86b69885e3c1789eccba6e01c2c9fd2dd25be19d
# Push it to GitHub
git push --set-upstream origin backport/backport-620-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-620-to-2.x.

reta added a commit to reta/opensearch-java that referenced this pull request Sep 15, 2023
…nsume the response (opensearch-project#620)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 86b6988)
dblock pushed a commit that referenced this pull request Sep 15, 2023
…nsume the response (#620) (#623)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 86b6988)
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Apache HttpClient5 default configuration allocates 100mb byte buffer per request
3 participants