Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GetFieldMappingResponse. #641

Merged

Conversation

MikePieperSer
Copy link
Contributor

Description

CHanges the parser to allow parsing mapping definition of multiple fields.

Issues Resolved

Closes [#587]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pieper <mike.pieper@ser.de>
Signed-off-by: pieper <mike.pieper@ser.de>
Signed-off-by: pieper <mike.pieper@ser.de>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the formatting.

item0.getValue().serialize(generator, mapper);

}
generator.writeEnd();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix tabs vs. spaces please.

Signed-off-by: pieper <mike.pieper@ser.de>
Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MikePieperSer!

@dblock dblock merged commit aea607a into opensearch-project:main Oct 3, 2023
29 checks passed
@VachaShah VachaShah added the backport 2.x Backport to 2.x branch label Oct 3, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-641-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aea607ae67a65155eeb090780309d99ed40c42ef
# Push it to GitHub
git push --set-upstream origin backport/backport-641-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-641-to-2.x.

VachaShah pushed a commit to VachaShah/opensearch-java that referenced this pull request Oct 3, 2023
* Fixed GetFieldMappingResponse.

Signed-off-by: pieper <mike.pieper@ser.de>

* Add Changelog.

Signed-off-by: pieper <mike.pieper@ser.de>

* Changelog fix.

Signed-off-by: pieper <mike.pieper@ser.de>

* Tabs vs. spaces fix.

Signed-off-by: pieper <mike.pieper@ser.de>

---------

Signed-off-by: pieper <mike.pieper@ser.de>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
MikePieperSer added a commit to MikePieperSer/opensearch-java that referenced this pull request Oct 4, 2023
* Fixed GetFieldMappingResponse.

Signed-off-by: pieper <mike.pieper@ser.de>

* Add Changelog.

Signed-off-by: pieper <mike.pieper@ser.de>

* Changelog fix.

Signed-off-by: pieper <mike.pieper@ser.de>

* Tabs vs. spaces fix.

Signed-off-by: pieper <mike.pieper@ser.de>

---------

Signed-off-by: pieper <mike.pieper@ser.de>
(cherry picked from commit aea607a)
dblock pushed a commit that referenced this pull request Oct 4, 2023
* Fixed GetFieldMappingResponse.



* Add Changelog.



* Changelog fix.



* Tabs vs. spaces fix.



---------

Signed-off-by: pieper <mike.pieper@ser.de>
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: MikePieperSer <41434171+MikePieperSer@users.noreply.github.com>
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants