Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Flat Objects #735

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

Bfindlay
Copy link
Contributor

Description

Describe what this change achieves.
"Flattened" is the elasticsearch variant and not recognised in opensearch. This PR removes the use of "flattened" and adds the "FlatObject" property type.

This is only supported from OpenSearch version 2.7.0 onwards
https://opensearch.org/docs/latest/field-types/supported-field-types/flat-object/

Issues Resolved

#720

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
dblock
dblock previously approved these changes Nov 20, 2023
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it just works? Nice.

reta
reta previously approved these changes Nov 20, 2023
@reta reta self-requested a review November 20, 2023 13:10
@Bfindlay Bfindlay marked this pull request as draft November 20, 2023 13:26
@dblock
Copy link
Member

dblock commented Nov 20, 2023

@Bfindlay Consider writing a complete working sample with the changes in https://github.com/opensearch-project/opensearch-java/tree/main/samples.

Signed-off-by: bfindlay <bfindlay@acm.org>
@Bfindlay Bfindlay dismissed stale reviews from reta and dblock via 10df60f November 21, 2023 03:19
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
@Bfindlay Bfindlay marked this pull request as ready for review November 21, 2023 04:32
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will leave @reta for a CR who knows a lot more about flat objects than me ;)

@reta reta merged commit a4dc4f0 into opensearch-project:main Nov 21, 2023
45 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Nov 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 21, 2023
* add flat object support

Signed-off-by: bfindlay <bfindlay@acm.org>

* add flat object support

Signed-off-by: bfindlay <bfindlay@acm.org>

* update changelog

Signed-off-by: bfindlay <bfindlay@acm.org>

* update flatobject and user guides

Signed-off-by: bfindlay <bfindlay@acm.org>

* fix typo

Signed-off-by: bfindlay <bfindlay@acm.org>

* remove unused comments

Signed-off-by: bfindlay <bfindlay@acm.org>

---------

Signed-off-by: bfindlay <bfindlay@acm.org>
(cherry picked from commit a4dc4f0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Nov 21, 2023
* add flat object support



* add flat object support



* update changelog



* update flatobject and user guides



* fix typo



* remove unused comments



---------


(cherry picked from commit a4dc4f0)

Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants