Fix MissingRequiredPropertyException on node stats response #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Bfindlay
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
dblock
approved these changes
Nov 26, 2023
java-client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractNodesIT.java
Outdated
Show resolved
Hide resolved
reta
previously approved these changes
Nov 30, 2023
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
dblock
approved these changes
Dec 1, 2023
reta
approved these changes
Dec 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
* fix stats null issues Signed-off-by: bfindlay <bfindlay@acm.org> * update changelog Signed-off-by: bfindlay <bfindlay@acm.org> * updated changelog Signed-off-by: bfindlay <bfindlay@acm.org> * use existing nodes itest Signed-off-by: bfindlay <bfindlay@acm.org> * fix test typo Signed-off-by: bfindlay <bfindlay@acm.org> * update itests Signed-off-by: bfindlay <bfindlay@acm.org> * spotless apply Signed-off-by: bfindlay <bfindlay@acm.org> --------- Signed-off-by: bfindlay <bfindlay@acm.org> (cherry picked from commit 261cab4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Dec 1, 2023
) * fix stats null issues * update changelog * updated changelog * use existing nodes itest * fix test typo * update itests * spotless apply --------- (cherry picked from commit 261cab4) Signed-off-by: bfindlay <bfindlay@acm.org> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
All of the properties in the stats response were marked as required. However as per opensearch API spec, the request can be modified to return only what is requested and therefore if you select a stat such as "fs" the deserialization of the response will fail as the "required" properties are not available.
This can be seen in the OpenSearch library that these are nullable in the repsonse https://github.com/opensearch-project/OpenSearch/blob/5bb6caec906f9e89d330332ebb74789571409eb1/server/src/main/java/org/opensearch/action/admin/cluster/node/stats/NodeStats.java#L78
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
#740
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.