Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup for GitHub pages #865

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

kolchfa-aws
Copy link
Contributor

Description

Sets up the necessary config and styling files for the GitHub pages theme.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I the only one who thinks the OpenSearch logo looks like a tilted smiley? (ツ)

@dbwiddis
Copy link
Member

The build.gradle failure on javadoc/spotless are fixed by #827, please merge or rebase.

@dbwiddis
Copy link
Member

LGTM, holding off on merging until opensearch-project/OpenSearch#8588 is merged, so that backport works more smoothly.

@kolchfa-aws
Copy link
Contributor Author

Sure, but I don't think we need to backport this one though. It should work off the main branch only.

@dbwiddis dbwiddis merged commit 936b840 into opensearch-project:main Jul 10, 2023
7 checks passed
@owaiskazi19
Copy link
Member

Sure, but I don't think we need to backport this one though. It should work off the main branch only.

@kolchfa-aws we will be releasing SDK in 2.9 from 1.x branch. I think the branch should be updated with the latest document changes. @dbwiddis IMO we should backport this to 1.x.

@dbwiddis
Copy link
Member

@dbwiddis IMO we should backport this to 1.x.

These docs live on a single branch (I'm not sure exactly which repo, but a gh-pages branch usually.) They won't get published from another branch. Probably doesn't hurt to backport but will never be read under current config.

DarshitChanpura pushed a commit to DarshitChanpura/opensearch-sdk-java that referenced this pull request Jul 10, 2023
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants