Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jooq version and address bind variable failure in AdmissionControl Emitter #493

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented Sep 30, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#492

Describe the solution you are proposing

  1. Update Jooq version to 3.16.20, compatible with sqlite version
  2. Fix error in AdmissionControl Emitter (AdmissionControl_RejectionCount configured with 5 columns but the AD Emitter code attempts to bind 6 values, causing failure)
  3. Jooq version upgrade related changes

Tested within RCA Docker container, No more org.jooq.tools.JooqLogger info INFO: Single batch : No bind variables have been provided with a single statement batch execution. This may be due to accidental API misuse present in [root@d47462e53343 logs]# cat PerformanceAnalyzer.log | grep bind

[root@d47462e53343 logs]# pwd
/usr/share/opensearch/logs
[root@d47462e53343 logs]# cat PerformanceAnalyzer.log  | grep bind

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…trol Emitter

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #493 (2056ca7) into main (2972bd8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 2056ca7 differs from pull request most recent head 9be2f89. Consider uploading reports for the commit 9be2f89 to get more accurate results

@@             Coverage Diff              @@
##               main     #493      +/-   ##
============================================
- Coverage     74.38%   74.37%   -0.02%     
+ Complexity     2663     2661       -2     
============================================
  Files           317      317              
  Lines         16301    16298       -3     
  Branches       1277     1277              
============================================
- Hits          12126    12121       -5     
- Misses         3660     3662       +2     
  Partials        515      515              
Files Coverage Δ
...manceanalyzer/rca/persistence/SQLitePersistor.java 75.21% <100.00%> (-0.09%) ⬇️
...rch/performanceanalyzer/reader/MetricsEmitter.java 94.82% <ø> (-0.01%) ⬇️

... and 3 files with indirect coverage changes

@khushbr khushbr merged commit 30ca0b3 into opensearch-project:main Oct 2, 2023
6 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 2, 2023
…trol Emitter (#493)

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 30ca0b3)
khushbr added a commit that referenced this pull request Oct 5, 2023
…trol Emitter (#493) (#494)

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 30ca0b3)

Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants