Add workflow to build and install security analytics dashboards plugin #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
=======================================
Coverage 31.03% 31.03%
=======================================
Files 157 157
Lines 5229 5229
Branches 925 925
=======================================
Hits 1623 1623
Misses 3419 3419
Partials 187 187 ☔ View full report in Codecov by Sentry. |
derek-ho
changed the title
derek-ho
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
derek-ho
commented
Feb 23, 2024
| @@ -106,7 +106,7 @@ jobs: | |||
| - name: Bootstrap plugin/OpenSearch-Dashboards | |||
| run: | | |||
| cd OpenSearch-Dashboards/plugins/security-analytics-dashboards-plugin | |||
| yarn osd bootstrap | |||
| yarn osd bootstrap --single-version=loose | |||
There was a problem hiding this comment.
This is necessary after core added a dependency on cypress 9.5.4. See opensearch-project/OpenSearch-Dashboards#5561 for more context
|
@AWSHurneyt @riysaxen-amzn can you take a look at this PR and leave any feedback? I think it will be helpful to catch issues early. |
AWSHurneyt
reviewed
Feb 28, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
This reverts commit ba9c4f6. Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
force-pushed
the
test-workflow
branch
from
5b2d337
to
634aae0
Compare
AWSHurneyt
approved these changes
Feb 28, 2024
amsiglan
reviewed
Mar 13, 2024
amsiglan
approved these changes
Mar 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
#899) * Initial commit to try using workflow from other fork Signed-off-by: Derek Ho <dxho@amazon.com> * setup with backend or job scheduler Signed-off-by: Derek Ho <dxho@amazon.com> * Use generalized workflows Signed-off-by: Derek Ho <dxho@amazon.com> * Extra dash Signed-off-by: Derek Ho <dxho@amazon.com> * Correct directory Signed-off-by: Derek Ho <dxho@amazon.com> * Revert "Add missing modules common and types (#875)" This reverts commit ba9c4f6. Signed-off-by: Derek Ho <dxho@amazon.com> * Revert "Revert "Add missing modules common and types (#875)"" This reverts commit 17cff14. Signed-off-by: Derek Ho <dxho@amazon.com> * Single version loose to fix bootstrapping issues Signed-off-by: Derek Ho <dxho@amazon.com> * Add v1 tag Signed-off-by: Derek Ho <dxho@amazon.com> * Remove security specific settings Signed-off-by: Derek Ho <dxho@amazon.com> * Remove references to security Signed-off-by: Derek Ho <dxho@amazon.com> * Add loose for windows Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 6bb078b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Mar 19, 2024
#899) (#958) * Initial commit to try using workflow from other fork * setup with backend or job scheduler * Use generalized workflows * Extra dash * Correct directory * Revert "Add missing modules common and types (#875)" This reverts commit ba9c4f6. * Revert "Revert "Add missing modules common and types (#875)"" This reverts commit 17cff14. * Single version loose to fix bootstrapping issues * Add v1 tag * Remove security specific settings * Remove references to security * Add loose for windows --------- (cherry picked from commit 6bb078b) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a workflow to build and install the security analytics plugin in to OSD, and verifies there are no run time failures. The current setup in which a development server is run (i.e. running yarn start from OSD root), does not catch issues such as imports and other intricacies that happen with the build and installation process. Inspired from: opensearch-project/opensearch-build#4115 (comment), this workflow will be helpful in catching cases like this.
To demonstrate the value of this PR, I reverted the recent fix that fixed some issues found at run time with the security analytics dashboards plugin, and verified that the workflow would have caught this: https://github.com/opensearch-project/security-analytics-dashboards-plugin/actions/runs/8023274575/job/21919423391. There are ways to catch this today, such as autocuts, but this workflow run on each PR will keep the repo in a good state and catch these issues early.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.