Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Sigma Aggregation rule fixes #639

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b838dd8 from #622

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit b838dd8)
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #639 (8baa9f7) into 2.x (f20bada) will increase coverage by 0.03%.
Report is 1 commits behind head on 2.x.
The diff coverage is 62.50%.

@@             Coverage Diff              @@
##                2.x     #639      +/-   ##
============================================
+ Coverage     25.02%   25.06%   +0.03%     
- Complexity      940      941       +1     
============================================
  Files           255      255              
  Lines         11127    11144      +17     
  Branches       1243     1247       +4     
============================================
+ Hits           2785     2793       +8     
- Misses         8090     8097       +7     
- Partials        252      254       +2     
Files Coverage Δ
...ecurityanalytics/rules/backend/OSQueryBackend.java 66.81% <100.00%> (ø)
.../securityanalytics/rules/backend/QueryBackend.java 64.54% <100.00%> (+0.32%) ⬆️
...curityanalytics/rules/objects/SigmaDetections.java 100.00% <100.00%> (ø)
...a/org/opensearch/securityanalytics/model/Rule.java 0.00% <0.00%> (ø)
...tyanalytics/rules/aggregation/AggregationItem.java 94.73% <66.66%> (-5.27%) ⬇️
...opensearch/securityanalytics/util/RuleIndices.java 0.00% <0.00%> (ø)
...ch/securityanalytics/findings/FindingsService.java 35.89% <50.00%> (-0.59%) ⬇️
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@sbcd90 sbcd90 merged commit f733685 into 2.x Oct 4, 2023
13 of 15 checks passed
@github-actions github-actions bot deleted the backport/backport-622-to-2.x branch October 4, 2023 22:09
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
… action on the same node (opensearch-project#631) (opensearch-project#639)

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant