Test for the type of function used to declare findingIds[Ishan Bhat] #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
ishanbhat2004
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
|
thanks for raising this PR @ishanbhat2004 Can you add more detail in the description regarding the change? It's not very clear what this PR aims to do |
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
Signed-off-by: Ishan Bhat <bhat52@purdue.edu>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Mar 25, 2024
…search-project#666) (opensearch-project#668) Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 0fb9dd04ccd1356b67e320173954cbc928eba4fd) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for the function to use to store findingIds
Issues Resolved
FindingIds can now be used to search for alerts in the database.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.