[Backport 2.11] #725 Sigma keywords field not handled correctly #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joanne Wang <jowg@amazon.com> * remove wildcard Signed-off-by: Joanne Wang <jowg@amazon.com> * changed wildcardtest Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed wildcards Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed wildcard query test Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed correlation engine tests Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed query backend tests Signed-off-by: Joanne Wang <jowg@amazon.com> * clean up Signed-off-by: Joanne Wang <jowg@amazon.com> * added two integration tests Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.11 #741 +/- ##
============================================
- Coverage 24.71% 24.63% -0.09%
+ Complexity 946 943 -3
============================================
Files 255 255
Lines 11376 11369 -7
Branches 1280 1279 -1
============================================
- Hits 2812 2801 -11
- Misses 8313 8318 +5
+ Partials 251 250 -1 ☔ View full report in Codecov by Sentry. |
jowg-amazon
changed the title
eirsep
approved these changes
Nov 30, 2023
praveensameneni
approved these changes
Nov 30, 2023
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
* added categories for log types Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Mar 25, 2024
…h-project#726) (opensearch-project#741) Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #725 to 2.11
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.