[Backport 2.9] #709 Return empty response for empty mappings and no applied aliases #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…724) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit c0f7bd9)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.9 #748 +/- ##
============================================
- Coverage 25.85% 25.82% -0.03%
Complexity 940 940
============================================
Files 252 252
Lines 10753 10753
Branches 1198 1198
============================================
- Hits 2780 2777 -3
- Misses 7726 7729 +3
Partials 247 247 ☔ View full report in Codecov by Sentry. |
jowg-amazon
approved these changes
Nov 30, 2023
eirsep
approved these changes
Nov 30, 2023
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Nov 30, 2023
…724) (#748) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit c0f7bd9) Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com> (cherry picked from commit 4f68164)
eirsep
pushed a commit
that referenced
this pull request
Nov 30, 2023
…724) (#748) (#758) * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit c0f7bd9) Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com> (cherry picked from commit 4f68164) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c0f7bd9 from #724