Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] #709 Return empty response for empty mappings and no applied aliases #749

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c0f7bd9 from #724

…724)

* #709 Return empty response for empty mappings and no applied aliases

Signed-off-by: Megha Goyal <goyamegh@amazon.com>

* Adding integ tests for empty mappings/aliases use-cases

Signed-off-by: Megha Goyal <goyamegh@amazon.com>

* Fix unit tests for MappingsTraverser

Signed-off-by: Megha Goyal <goyamegh@amazon.com>

---------

Signed-off-by: Megha Goyal <goyamegh@amazon.com>
(cherry picked from commit c0f7bd9)
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (80e028d) 24.71% compared to head (04b9181) 24.69%.
Report is 1 commits behind head on 2.11.

Files Patch % Lines
...ch/securityanalytics/mapper/MappingsTraverser.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.11     #749      +/-   ##
============================================
- Coverage     24.71%   24.69%   -0.03%     
  Complexity      946      946              
============================================
  Files           255      255              
  Lines         11376    11376              
  Branches       1280     1280              
============================================
- Hits           2812     2809       -3     
- Misses         8313     8316       +3     
  Partials        251      251              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon merged commit a8d734a into 2.11 Dec 1, 2023
12 of 15 checks passed
@github-actions github-actions bot deleted the backport/backport-724-to-2.11 branch December 1, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants