Fix tests for sigma rule with null condition for 2.11 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joanne Wang <jowg@amazon.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.11 #772 +/- ##
============================================
- Coverage 24.71% 24.63% -0.09%
Complexity 946 946
============================================
Files 255 255
Lines 11376 11369 -7
Branches 1280 1279 -1
============================================
- Hits 2812 2801 -11
- Misses 8313 8319 +6
+ Partials 251 249 -2 ☔ View full report in Codecov by Sentry. |
praveensameneni
approved these changes
Dec 7, 2023
eirsep
approved these changes
Dec 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit e06858d)
jowg-amazon
added a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix integ test and unit tests for sigma rule with null condition in 2.11
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.