Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] updated lucene MAX_DIMENSIONS path #785

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3c9b23a from #607

Signed-off-by: Wang <jowg@6c7e67cb99a2.ant.amazon.com>
(cherry picked from commit 3c9b23a)
@amsiglan
Copy link
Collaborator

is this not required in main? why is the PR raise to 2.x directly?

Looks like a backport

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8134882) 24.80% compared to head (a73e8c8) 24.79%.
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...arch/securityanalytics/logtype/LogTypeService.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #785      +/-   ##
============================================
- Coverage     24.80%   24.79%   -0.01%     
+ Complexity     1019     1016       -3     
============================================
  Files           275      275              
  Lines         12671    12676       +5     
  Branches       1390     1390              
============================================
  Hits           3143     3143              
- Misses         9260     9263       +3     
- Partials        268      270       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amsiglan amsiglan merged commit 0e02300 into 2.x Dec 21, 2023
6 of 16 checks passed
@github-actions github-actions bot deleted the backport/backport-607-to-2.x branch December 21, 2023 21:59
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
* added release notes

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated release notes

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
…ch-project#750) (opensearch-project#785)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 830dff1d17c9a002efe417b55b84219b14c0c2fe)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants