Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] install_dashboards github action is not properly handling multi-digit major or minor versions #1532

Closed
cwperks opened this issue Aug 1, 2023 · 1 comment
Assignees
Labels
bug Something isn't working triaged

Comments

@cwperks
Copy link
Member

cwperks commented Aug 1, 2023

Now that 2.x is on 2.10, its exposed an issue on the install-dashboards Github Action which has logic to extract the branch name and major version from package.json. The commands are currently using cut and assuming that the major and minor versions are both single digits which is not the case now.

Problematic Block: https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/actions/install-dashboards/action.yml#L41-L46

This is currently block the version increment PR in the 2.x branch: #1526

@cwperks cwperks added bug Something isn't working untriaged labels Aug 1, 2023
@cwperks cwperks changed the title [BUG] install_dashboards github action is not properly handling multi-digit major versions or minor versions [BUG] install_dashboards github action is not properly handling multi-digit major or minor versions Aug 1, 2023
@RyanL1997
Copy link
Collaborator

Closing this due to the merge of #1537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

3 participants